Bugfix for adjusting parameter values #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving the slider on a numeric param with min + max values was causing a loop of updates
cjmayo
reviewed
Dec 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 81.31% 81.30% -0.02%
==========================================
Files 55 55
Lines 10885 10835 -50
==========================================
- Hits 8851 8809 -42
+ Misses 2034 2026 -8
Continue to review full report at Codecov.
|
Once Upon a Time we supported different Gtk+ versions which behaved differently for menus, but that is no longer an issue.
They were all messed up. Colors are now displayed correctly. Color editor displayed in more useful mode. Fractal redraws after color change.
|
This pull request introduces 1 alert when merging b90d5dc into 048a3f0 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC doc ought to be in another PR but oh well